New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
search plugin: do not crash on missing lang options, inform instead #2602
Conversation
ultrabug
commented
Oct 8, 2021
- fallback to english on missing search.lang option
- support search.lang territory pt_BR -> pt
- fallback to english on missing search.lang option - support search.lang territory pt_BR -> pt
This replaces #2564 to address your points #2535 (comment) with #2535 (comment) Example output:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The approach looks good to me. Let's get this done :)
CI is failing, though 😬
Fixing tests now, should be good soon |
Good for me now 👍 |
Thanks for the review @oprypin |
Ah thanks for the great fix. @ultrabug so you probably saw that I mentioned that a release is coming on Sunday [today] |
Yes mate indeed, I'll check the pt_BR PR out later today, thanks |