Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert livereload file watching to use polling observer #2477

Merged
merged 1 commit into from Jul 8, 2021
Merged

Revert livereload file watching to use polling observer #2477

merged 1 commit into from Jul 8, 2021

Commits on Jun 27, 2021

  1. Revert livereload file watching to use polling observer 

    This goes back to the approach that was always used with 'livereload' library (but now just using the 'watchdog' implementation of the same), meaning the same downsides with latency and CPU usage.
But we have to do this to reasonably support usages that span virtual filesystems such as non-native Docker and network mounts.

This also simplifies the code, as the polling observer already follows symlinks and happens to support watching paths of files directly
    @oprypin
    oprypin committed Jun 27, 2021
    Copy the full SHA
    735e4a0 View commit details
    Browse the repository at this point in the history