Skip to content

Commit

Permalink
Don't return trigger characters for ambient JS suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
mjbvz committed Aug 12, 2021
1 parent 104bc57 commit 1b3678b
Showing 1 changed file with 6 additions and 2 deletions.
Expand Up @@ -89,7 +89,7 @@ class MyCompletionItem extends vscode.CompletionItem {
this.useCodeSnippet = completionContext.useCodeSnippetsOnMethodSuggest && (this.kind === vscode.CompletionItemKind.Function || this.kind === vscode.CompletionItemKind.Method);

this.range = this.getRangeFromReplacementSpan(tsEntry, completionContext);
this.commitCharacters = MyCompletionItem.getCommitCharacters(completionContext);
this.commitCharacters = MyCompletionItem.getCommitCharacters(completionContext, tsEntry);
this.insertText = isSnippet && tsEntry.insertText ? new vscode.SnippetString(tsEntry.insertText) : tsEntry.insertText;
this.filterText = this.getFilterText(completionContext.line, tsEntry.insertText);

Expand Down Expand Up @@ -489,7 +489,11 @@ class MyCompletionItem extends vscode.CompletionItem {
}
}

private static getCommitCharacters(context: CompletionContext): string[] | undefined {
private static getCommitCharacters(context: CompletionContext, entry: Proto.CompletionEntry): string[] | undefined {
if (entry.kind === PConst.Kind.warning) { // Ambient JS word based suggestion
return undefined;
}

if (context.isNewIdentifierLocation || !context.isInValidCommitCharacterContext) {
return undefined;
}
Expand Down

0 comments on commit 1b3678b

Please sign in to comment.