New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print documentation links of rule #54
Conversation
package.json
Outdated
@@ -43,7 +43,7 @@ | |||
"typescript": "^4.1.2" | |||
}, | |||
"dependencies": { | |||
"cli-table": "^0.3.6", | |||
"cli-table": "msabramo/cli-table#GH-147", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/eslint.ts
Outdated
overrideConfig: { plugins }, | ||
}); | ||
// eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
const rulesMeta: ESLint.LintResultData['rulesMeta'] | undefined = (eslint as any).getRulesMetaForResults?.(results); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getRulesMetaForResults
is a feature added in ESLint 7.29.0.- Therefore, the function may not exist in versions lower than 7.29.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All blockers have been resolved and we are ready to proceed. |
close: #31
blocked: Automattic/cli-table#149, DefinitelyTyped/DefinitelyTyped#56950