Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Precommit qmlformat crash fixes #11078

Merged
merged 2 commits into from
Nov 19, 2022
Merged

Precommit qmlformat crash fixes #11078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb55569
Fixed entry for qmlformat
JoergAtGithub Nov 19, 2022
1f5d7fa
Prevent crash on Windows due to use of uninitialized variable
JoergAtGithub Nov 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,9 +141,9 @@ repos:
files: ^CHANGELOG.md$
- id: qmlformat
name: qmlformat
entry: tools/qmlformat.py
entry: python tools/qmlformat.py
pass_filenames: true
language: system
language: python
types: [text]
files: ^.*\.qml$
- id: qmllint
Expand Down
1 change: 1 addition & 0 deletions tools/qmlformat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ def find_qt_version():


def main(argv=None):
qmlformat_executable = None
# First look up at the most common location for QT6 which is
# usually not in PATH
if sys.platform != "win32":
Expand Down