New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing config.secret to types #225

Open

gierschv wants to merge 1 commit into mixpanel:master from gierschv:fix/missing-ts-secret

gierschv commented Oct 2, 2023

The release 0.18.0 broke the usage of this library using TypeScript and secret in the config:

error TS2345: Argument of type '{ host: string; secret: string; debug: boolean; }' is not assignable to parameter of type 'Partial<InitConfig>'.
Object literal may only specify known properties, and 'secret' does not exist in type 'Partial<InitConfig>'.


          fix: add missing config.secret to types

d48d5b6

lsthornt commented Nov 6, 2023

Just here to add a +1 confirming that this change works in our codebase, and fixes the type issue noted in the description.

willemclarke mentioned this pull request

Typescript error when using secret #227

Open

triqi approved these changes

View reviewed changes

boredland mentioned this pull request

🐛 Add secret option to InitConfig #232

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment