Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security patch] Apply MitM security patch from https-proxy-agent #156

Merged

Conversation

omrilotan
Copy link
Contributor

@omrilotan omrilotan commented Oct 8, 2019

https-proxy-agent version 2.2.1 contains a reported man-in-the-middle vulnerability. A security patch was issued and released in version 3.0.0.

This mejor version does not include breaking changes in the code but has removed support to legacy node engines (4,5,7). Code is still tested on 6, 8, 10, 12.

I would like to include this security patch here.

Version 3.0.0 release notes

This release fixes the MitM vulnerability reported via HackerOne. It is a breaking change because Node 4, 5, and 7 are no longer tested in CI (note that Node 6 is still supported).

Major Changes

  • Remove Node 5 and 7 from Travis: 590bc8b
  • Remove Node 4 from Travis: 6c804a2

Minor Changes

  • Update proxy to v1.0.0: d0e3c18
  • Test on Node.js 10 and 12: 3535951
  • Fix compatibility with Node.js >= 10.0.0: #73
  • Add .editorconfig file: 06ead2f
  • Add .eslintrc.js file: ae53572

Patches

  • Update README with correct secureProxy behavior: #65
  • Remove unreachable code: 46aad09
  • [TypeScript] Allow port to be a string: #72
  • Use an EventEmitter to replay failed proxy connect HTTP requests: #77

Credits

Huge thanks to @lpinca@stoically, and @zkochan for helping!

@tdumitrescu tdumitrescu merged commit 81f19c2 into mixpanel:master Oct 9, 2019
@tdumitrescu
Copy link
Member

Upgraded in v0.10.3, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants