Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Michael,
Good news! I managed to get everything building on my mac. I made a few updates in the process.
The major thing I have done is added Poetry for package management. Here is my motivation for this:
poetry install
).However I'm not sure about your preferences for package managment or what the best practice is in PyTorch projects. If you have a standard approach then just let me know and I will change it over! Also -- maybe this is all overkill since this is just a pet project.
The main challenge was including the PyTorch dependency, since this platform dependent. I think this S/O question describes it better than I could, and this comment seems like a viable way we could change the dependency based on platform.
The solution I have used seems like it might be brittle for a couple of reasons:
Other approaches I considered:
Hope it isn't too bold of me to suggest this! Due to timezones I thought it would be best to write everything down and let you review it async, but maybe would be better to have had a discussion since I am probably missing a lot of context. Also happy to scrap this for now and manage my dependencies locally.
Let me know your thoughts! Happy to chat about this on a call today or tomorrow.
Apart from that, I made a few other, minor changes:
process_urls
function