Fixed an out of bounds error in cargo-insta

mitsuhiko · Jul 23, 2022 · cae792f · cae792f
1 parent 8f659ec
commit cae792f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,11 @@
 
 All notable changes to insta and cargo-insta are documented here.
 
+## 0.17.0
+
+- Fixed an issue in `cargo-insta` where sometimes accepting inline snapshots
+  would crash with an out of bounds panic.
+
 ## 1.16.0
 
 - Added `--no-quiet`/`-Q` flag to `cargo insta test` to suppress the

diff --git a/cargo-insta/src/inline.rs b/cargo-insta/src/inline.rs
@@ -158,7 +158,11 @@ impl FilePatcher {
                 tokens: &[TokenTree],
                 indentation: usize,
             ) -> bool {
-                match &tokens[tokens.len() - 2] {
+                if tokens.len() < 2 {
+                    return false;
+                }
+
+                match tokens[tokens.len() - 2] {
                     TokenTree::Punct(ref punct) if punct.as_char() == '@' => {}
                     _ => {
                         return false;