Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/slugs #97

Merged
merged 4 commits into from Mar 7, 2023
Merged

Bugfix/slugs #97

merged 4 commits into from Mar 7, 2023

Conversation

GavMason
Copy link
Contributor

@GavMason GavMason commented Mar 2, 2023

Goal: Resolve bug with pages not redirecting upon the error of invlaid slug url parameter.

Resolves #89

Signed-off-by: Gavin Mason <75515923+GavMason@users.noreply.github.com>
Signed-off-by: Gavin Mason <75515923+GavMason@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Mar 2, 2023

Deploy Preview for mitre-saf-demo ready!

Name Link
🔨 Latest commit 0e09993
🔍 Latest deploy log https://app.netlify.com/sites/mitre-saf-demo/deploys/64076f597b663700086c1fe2
😎 Deploy Preview https://deploy-preview-97--mitre-saf-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 2, 2023

Deploy Preview for mitre-saf-v2 ready!

Name Link
🔨 Latest commit 0e09993
🔍 Latest deploy log https://app.netlify.com/sites/mitre-saf-v2/deploys/64076f59c4ac080008e647e8
😎 Deploy Preview https://deploy-preview-97--mitre-saf-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Signed-off-by: Gavin Mason <75515923+GavMason@users.noreply.github.com>
Signed-off-by: Gavin Mason <75515923+GavMason@users.noreply.github.com>
Copy link
Contributor

@ChrisHinchey ChrisHinchey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@GavMason GavMason merged commit 90b7e44 into main Mar 7, 2023
@aaronlippold aaronlippold deleted the bugfix/slugs branch March 18, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error Handling for invaid slugs
2 participants