Resolve new linting rules from flake8 #2663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
elegantmoose
approved these changes
Oct 4, 2022
clenk
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to the addition of a new rule in
flake8-bugbear(ref. PyCQA/flake8-bugbear#287), the test harness functions needed some parameter adjustment to pass linting.This PR also removes the
pyminizippip requirement from core and moves it to theemuplugin which requires it when executing adversary emulation plans. See corresponding changes in mitre/emu#29 that should be merged along with this change.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Ran test harness locally and through pipeline to ensure functionality.
Checklist: