Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linting, formatting #1831

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Update linting, formatting #1831

merged 2 commits into from
Jun 8, 2023

Conversation

ChristopherChudzicki
Copy link
Contributor

@ChristopherChudzicki ChristopherChudzicki commented Jun 1, 2023

Pre-Flight checklist

  • Testing
    • Code is tested
    • Changes have been manually tested

What are the relevant tickets?

#1829 , #1832

What's this PR do?

Currently, if we update Typescript, we will get warnings like

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript->eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <4.9.0

YOUR TYPESCRIPT VERSION: 4.9.5

Please only submit bug reports when using the officially supported version.

To resolve this warning (and to use new TS features like satisfies) we need to update Prettier from v1 to v2.

Unfortunately... Prettier changed how it handles chained method calls from v1 to v2. See prettier/prettier#7884 for details. IMO the v1 way looked better for fluent APIs like enzyme has, but...whatever. We should stop using Enzyme anyway.

How should this be manually tested?

The only changes here are autofixes by Prettier v2. There should be no behavior change.

So... run Studio and make sure it works. Be sure to either docker compose up or manually docker exec watch yarn install

@ChristopherChudzicki ChristopherChudzicki changed the title Cc/update prettier Update linting, formatting Jun 1, 2023
@ChristopherChudzicki ChristopherChudzicki marked this pull request as ready for review June 1, 2023 18:28
@HussainTaj-arbisoft HussainTaj-arbisoft self-assigned this Jun 8, 2023
Copy link
Contributor

@HussainTaj-arbisoft HussainTaj-arbisoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

I tried every UI element I could see.

  • Edited all the content of an existing course and www site
  • Created a new course from scratch, populated and published it

Everything is working.

@ChristopherChudzicki ChristopherChudzicki merged commit 2e5f814 into master Jun 8, 2023
3 checks passed
This was referenced Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants