Self contained front end and fixes for building on Heroku #829
Conversation
…sponses or sets on query cache
frontends/package.json
Outdated
There was a problem hiding this comment.
Any reason to have this in addition to the root level package.json? Having 2 levels of workspaces (root + frontends/workspace-name/` seems simpler than having 3 levels (root, + frontends/ + frontends/workspace-name/)
There was a problem hiding this comment.
The goal is for frontends to be self-contained. Unfortunately the issue of Heroku needing to find the package.json at root meant that it needed to be reintroduced there though, as we should only be needing to build the front end there temporarily, it seemed sensible to only pull what is needed to build rather than add all the front end test and lint config files etc back to the project root, so that we can more easily remove from the root once the front end is served elsewhere.
…0). Increase timeouts on slow running tests
|
This change fixes the react and react-dom versions to 18.2.0. Described in testing-library/react-testing-library#1310, there is an issue with 18.3.0 conflicting with @testing-library that breaks a lot of tests with error: |
React released 18.3.1 last Friday to export |
| Run the front end with: | ||
|
|
||
| ```bash | ||
| yarn watch |
There was a problem hiding this comment.
| yarn watch | |
| yarn workspace frontends watch |
There was a problem hiding this comment.
I've added package scripts at root for these.
… moved to frontends so available inside container
What are the relevant tickets?
Load session from API and configure decoupled frontend for local development #616
Description (What does it do?)
Includes Self contained front end using Webpack to build HTML and Webpack Dev Server to serve #678 which failed to release due to the front end not being buildable on Heroku with the front end package and yarn workspace root having moved from the project root. The Heroku build has been tested and is successful.
The additional changes add the package.json back to the project root, though keep the frontends/package.json to retain a degree of self-contained frontend (Typescript, Jest configs and the watch container Dockerfile now live in
./frontends).The
watchcontainer Dockerfile again needs the project root as the build context. There is a wider issue of yarn workspaces having the issue for monorepo setups that by hoisting node_modules and the lockfile to the workspace root, we don't have independently deployable workspaces that can be used as Docker context.This also upgrades Yarn to 4.1.1 as I was having issues with the nesting resulting from the intermediary workspace in
./frontends. Anin-workspacespackage.json scripts excludes this and the root from being treated as workspaces for the previousyarn foreachcommands.How can this be tested?
Detail in #678