Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PyInstaller spec to set the u (unbuffered) flag #6821

Merged
merged 3 commits into from Apr 28, 2024
Merged

Update PyInstaller spec to set the u (unbuffered) flag #6821

merged 3 commits into from Apr 28, 2024

Conversation

Prinzhorn
Copy link
Member

@Prinzhorn Prinzhorn commented Apr 25, 2024 •
edited

Description

Fixes #6757

Checklist

  • I have updated tests where applicable.
  • I have added an entry to the CHANGELOG.
  • Only set this for mitmdump because I'm paranoid

@Prinzhorn Prinzhorn mentioned this pull request Apr 25, 2024
Closed
@Prinzhorn
Copy link
Member Author

Can confirm, I downloaded the artifact and now I immediately get stdout.

@Prinzhorn
Copy link
Member Author

Will test the next artifact and then we're good if there are no objections

@Prinzhorn Prinzhorn requested a review from mhils April 25, 2024 17:45
@Prinzhorn Prinzhorn changed the title WIP: Update PyInstaller spec to set the u (unbuffered) flag Update PyInstaller spec to set the u (unbuffered) flag Apr 25, 2024
@Prinzhorn Prinzhorn merged commit 14d5fa0 into mitmproxy:main Apr 28, 2024
23 checks passed
@Prinzhorn Prinzhorn deleted the unbuffered_io branch April 28, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhils mhils mhils approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mitmdump stdout never reaches parent process
2 participants
@Prinzhorn @mhils