Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --show-ignored-hosts #6720

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

NicolaiSoeborg
Copy link

@NicolaiSoeborg NicolaiSoeborg commented Mar 7, 2024

Description

Maybe a bit counterintuitive, but mitmproxy is very nice even without the MITM part. When doing --ignore-hosts '.*' it is not possible to see SNI's, so add new flag to show the raw TCP/UDP streams.

Fixes #6421

Running mitmproxy --ignore-hosts '.*' --show-ignored-hosts:

image

Checklist

  • I have updated tests where applicable.
  • I have added an entry to the CHANGELOG.

Maybe a bit counterintuitive, but mitmproxy is very nice even without
the MITM part.  When doing `--ignore-hosts '.*'` it is not possible to
see SNI's, so add new flag to show the raw TCP/UDP streams.

Fixes mitmproxy#6421
@mhils
Copy link
Member

mhils commented Mar 11, 2024

User question: Do you ever have an interest in viewing the raw contents here?

I like how this gets us pretty close to what we want with very little effort. But ideally I'd really like to see a dedicated flow subclass that does not keep encrypted gibberish in memory and that allows for a better UI integration.

@NicolaiSoeborg
Copy link
Author

My use-case is just to easily see the SNI :)

True that keeping the (encrypted) request in mem might be a bit of a waste - I could look into deleting it if we want to do that?
A dedicated flow type would be nice, but not sure I have the time :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log ignored requests (--ignore-hosts) that are forwarded
2 participants