New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for ~b
, ~bq
, and ~bs
filters in mitmweb
.
#6538
base: main
Are you sure you want to change the base?
Conversation
…o feature_mitmweb-body-search # Conflicts: # mitmproxy/tools/web/app.py
…o feature_mitmweb-body-search
…o feature_mitmweb-body-search
…o feature_mitmweb-body-search
…o feature_mitmweb-body-search
Hi @mhils, Thank you for your time and consideration. Best regards, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks good so far, but unfortunately does not support flows as-they-appear. For example, if I specify ~b foo
first and only then a flow with foo
in the body arrives, it will not be shown until I modify/resubmit the filter.
Of course, implementing live search is significantly harder (we don't want to issue a new request every time a flow arrives). So we'd need to somehow tell the server via the existing WebSocket connection and then have the server-side mark requests as it transmits them. I know this is a major change, but do you see what I am aiming for?
Perhaps a warning about this type of behavior? It's not the best, but it is somewhat understandable. |
any process on this? |
Description
This PR implements the
~b
,~bq
, and~bs
filters inmitmweb
. These filters allow users to search or highlight response body contents, thereby enhancing the usability and functionality ofmitmweb
.Previously, a user indicated in issue #3609 that the
~bs
(response body) implementation was not yet available inmitmweb
. This update addresses that concern and extends the filtering capability to include~b
and~bq
filters as well.This feature will significantly improve user experience, based on response body is crucial for efficient data analysis.
Looking forward to feedback and suggestions for improvement.
Checklist