Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for ~b, ~bq, and ~bs filters in mitmweb. #6538

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

dsphper
Copy link
Contributor

@dsphper dsphper commented Dec 7, 2023

Description

This PR implements the ~b, ~bq, and ~bs filters in mitmweb. These filters allow users to search or highlight response body contents, thereby enhancing the usability and functionality of mitmweb.

Previously, a user indicated in issue #3609 that the ~bs (response body) implementation was not yet available in mitmweb. This update addresses that concern and extends the filtering capability to include ~b and ~bq filters as well.

This feature will significantly improve user experience, based on response body is crucial for efficient data analysis.

Looking forward to feedback and suggestions for improvement.

Checklist

  • I have updated tests where applicable.
  • I have added an entry to the CHANGELOG.

@dsphper
Copy link
Contributor Author

dsphper commented Dec 11, 2023

Hi @mhils,
Could you please take a look and let me know if there are any additional improvements or changes you'd recommend? Any feedback would be greatly appreciated, as I aim to make this feature as useful as possible for the community.

Thank you for your time and consideration.

Best regards,

Copy link
Member

@mhils mhils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good so far, but unfortunately does not support flows as-they-appear. For example, if I specify ~b foo first and only then a flow with foo in the body arrives, it will not be shown until I modify/resubmit the filter.

Of course, implementing live search is significantly harder (we don't want to issue a new request every time a flow arrives). So we'd need to somehow tell the server via the existing WebSocket connection and then have the server-side mark requests as it transmits them. I know this is a major change, but do you see what I am aiming for?

@ddxv
Copy link
Contributor

ddxv commented Feb 2, 2024

Thanks! This looks good so far, but unfortunately does not support flows as-they-appear. For example, if I specify ~b foo first and only then a flow with foo in the body arrives, it will not be shown until I modify/resubmit the filter.

Of course, implementing live search is significantly harder (we don't want to issue a new request every time a flow arrives). So we'd need to somehow tell the server via the existing WebSocket connection and then have the server-side mark requests as it transmits them. I know this is a major change, but do you see what I am aiming for?

Perhaps a warning about this type of behavior? It's not the best, but it is somewhat understandable.

@gjrtimmer
Copy link

any process on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants