Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "CONTRIBUTING.md: temporarily remove --cov" #6520

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mhils
Copy link
Member

@mhils mhils commented Dec 2, 2023

This reverts commit 439e526, which temporarily disabled coverage reporting to work around a PyO3 bug. We should re-add this once the following commands work again:

cd test/mitmproxy/addons
pytest --cov mitmproxy.addons.anticache --cov-report term-missing --looponfail test_anticache.py

Currently this is at least blocked on the release of cryptography 42.0. :)

refs #6515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant