Load config files before applying cmdargs options. Fixes #6014 #6043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesolowski-gh
force-pushed
the
issue-6014
branch
from
34c827f
to
3673ab7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's an attempt to fix issue 6014. I've moved config files loading before applying options from command line arguments. I'm not sure it's a correct solution thou because it still separately notifies about changes of options from config files and command line arguments. I think it would be better to merge options from config files and command line (where the first ones are overwritten by the second ones) and only then once notify about changed option values.
Resolves #6014