New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added metadata view in mitm\web #5983
base: main
Are you sure you want to change the base?
Conversation
I assume you or the editor you're using were doing some automatic code formatting. This makes it hard to focus on the actual changes. We should definitely clean this up at some point (e.g. mixed single/double quotes or missing spaces) but it would be better not to have these changes in this PR. |
I tried to have the proper formatting for web but there is no formatter config available |
I've opened #5984 to fix this in the future. For now I recommend disabling any formatting your editor does. That's a recommendation I would give in general when contributing to a project. Formatting changes make PRs unnecessarily noisy. Unrelated code should not be touched. |
Ok i will submit make the changes and push it |
ignore: to make it easy to compare changes changes made in mitm web |
Perfect, I think that's good for a first iteration. Two small changes:
|
@Prinzhorn |
mitmproxy/flow.py
Outdated
@@ -126,7 +126,7 @@ def __init__( | |||
self._backup: Flow | None = None | |||
self.marked: str = "" | |||
self.is_replay: str | None = None | |||
self.metadata: Any = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if i change this to a lot of test start failing so should a leave metadata as empty dict
or it must initialized with None
self.metadata: Any = None
Description
closes #5704
Checklist
I don't think any test is required in this case