Cleanup #4363
Merged
Cleanup #4363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is not needed anymore with sans-io
Kriechi
reviewed
Dec 20, 2020
Kriechi
reviewed
Dec 20, 2020
| @@ -52,6 +49,7 @@ def test_create_logfun(self): | |||
| tls.MasterSecretLogger.create_logfun("test"), | |||
| tls.MasterSecretLogger) | |||
| assert not tls.MasterSecretLogger.create_logfun(False) | |||
| """ | |||
There was a problem hiding this comment.
just temporary - or whats the plan?
There was a problem hiding this comment.
Yes. I have thoroughly cleaned up the TLS implementation (draft PR in a second), but that currently depends on a cryptography release followed by a pyOpenSSL PR (pyca/pyopenssl#985) followed by a pyOpenSSL release.
Kriechi
approved these changes
Dec 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Kriechi: I also want some of the cake, here are ~2000 more lines! 馃槃
As a bonus, this PR reduces test time on Windows by 50%. 馃コ