Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty keyName when decoding struct -> map with omitempty #281

Merged
merged 1 commit into from Apr 20, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion mapstructure.go
Expand Up @@ -927,7 +927,9 @@ func (d *Decoder) decodeMapFromStruct(name string, dataVal reflect.Value, val re
return fmt.Errorf("cannot squash non-struct type '%s'", v.Type())
}
}
keyName = tagValue[:index]
if keyNameTagValue := tagValue[:index]; keyNameTagValue != "" {
keyName = keyNameTagValue
}
} else if len(tagValue) > 0 {
if tagValue == "-" {
continue
Expand Down
23 changes: 23 additions & 0 deletions mapstructure_bugs_test.go
@@ -1,6 +1,7 @@
package mapstructure

import (
"fmt"
"reflect"
"testing"
"time"
Expand Down Expand Up @@ -601,3 +602,25 @@ func TestMapSquash(t *testing.T) {
t.Fatal("expected false")
}
}

// GH-238: Empty key name when decoding map from struct with only omitempty flag
func TestMapOmitEmptyWithEmptyFieldnameInTag(t *testing.T) {
type Struct struct {
Username string `mapstructure:",omitempty"`
Age int `mapstructure:",omitempty"`
}

s := Struct{
Username: "Joe",
}
var m map[string]interface{}

if err := Decode(s, &m); err != nil {
t.Fatal(err)
}

expect := "map[Username:Joe]"
if got := fmt.Sprintf("%+v", m); expect != got {
t.Fatalf("expect %q, got: %s", expect, got)
}
}