Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decodeMapFromSlice should ignore ZeroFields when not first element #276

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

timestee
Copy link

Thanks for this project, I've had a config file merge and load implementation using this project, and got a wired problem: sandwich-go/xconf#6

for i := 0; i < dataVal.Len(); i++ {
err := d.decode(
name+"["+strconv.Itoa(i)+"]",
dataVal.Index(i).Interface(), val)
if err != nil {
return err
}
}

Should decodeMapFromSlice ignore ZeroFields when i != 0 ? Otherwise, the merged map will be clean again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant