Allow decoding embedded struct pointer in decodeMapFromStruct #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, but do you mind pulling this out into a separate standalone test case vs. overloading another? That makes it easier to remember what the test is addressing. |
|
A new test case was added just for this. |
codecat
reviewed
Jul 15, 2020
| @@ -2316,17 +2351,12 @@ func TestDecode_StructTaggedWithOmitempty_KeepNonEmptyValues(t *testing.T) { | |||
| VisibleMapField: nil, | |||
| OmitMapField: map[string]interface{}{"k": "v"}, | |||
| NestedField: nil, | |||
| OmitNestedField: &Nested{}, | |||
| OmitNestedField: nil, | |||
There was a problem hiding this comment.
Was this change intended? Looks a bit suspicious to me.
There was a problem hiding this comment.
Yes, this is intended. This PR change the behavior of struct pointer to allow decoding them. This means that &Nested{} is no longer considered nil once decoded; it will be a empty map[string]interface{}. Since this is not what is tested here, a separate unit test (TestNestedTypeStructPointer) was added just for this and this test was modified to pass nil so that it is not overloaded.
|
Fixed by #205 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may address #156 , but it is not my use case, so I did not validated this case particularly.