Fix #1298 gyroscope: invalid orientation in landscape

mistic100 · May 18, 2024 · 35e94cb · 35e94cb
1 parent 16150cc
commit 35e94cb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/packages/gyroscope-plugin/src/GyroscopePlugin.ts b/packages/gyroscope-plugin/src/GyroscopePlugin.ts
@@ -145,7 +145,6 @@ export class GyroscopePlugin extends AbstractConfigurablePlugin<
 
                 // force reset
                 this.controls.deviceOrientation = null;
-                this.controls.screenOrientation = 0;
                 this.controls.alphaOffset = 0;
 
                 this.state.alphaOffset = this.config.absolutePosition ? 0 : null;

diff --git a/packages/markers-plugin/src/utils.ts b/packages/markers-plugin/src/utils.ts
@@ -9,6 +9,8 @@ function greatArcIntermediaryPoint(p1: [number, number], p2: [number, number], f
     const [λ1, φ1] = p1;
     const [λ2, φ2] = p2;
 
+    // note: "r" should be the angular distance, see "intermediatePointTo" in the above article
+    // but "greatArcDistance" gives identiqual results up to 0.00001 radians and is faster
     const r = utils.greatArcDistance(p1, p2);
     const a = Math.sin((1 - f) * r) / Math.sin(r);
     const b = Math.sin(f * r) / Math.sin(r);