Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(backend): Remove unused injections #11462

Merged
merged 2 commits into from
Aug 5, 2023

Conversation

woxtu
Copy link
Contributor

@woxtu woxtu commented Aug 4, 2023

What

使われていないDIを削除します。

Why

Resolve #10243.

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Aug 4, 2023
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #11462 (648a1f1) into develop (b465bcd) will decrease coverage by 0.25%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #11462      +/-   ##
===========================================
- Coverage    78.86%   78.62%   -0.25%     
===========================================
  Files          922      921       -1     
  Lines        98009    97433     -576     
  Branches      7865     7694     -171     
===========================================
- Hits         77296    76607     -689     
- Misses       20713    20826     +113     
Files Changed Coverage Δ
packages/backend/src/core/AccountUpdateService.ts 100.00% <ø> (ø)
packages/backend/src/core/DeleteAccountService.ts 100.00% <ø> (ø)
packages/backend/src/core/SignupService.ts 98.05% <ø> (-0.05%) ⬇️
...backend/src/core/TwoFactorAuthenticationService.ts 34.75% <ø> (-0.58%) ⬇️
...ges/backend/src/core/activitypub/ApInboxService.ts 18.73% <ø> (-0.43%) ⬇️
...ges/backend/src/core/entities/RoleEntityService.ts 88.75% <ø> (-0.41%) ⬇️
...backend/src/core/entities/UserListEntityService.ts 90.69% <ø> (-0.61%) ⬇️
...e/processors/AggregateRetentionProcessorService.ts 39.13% <ø> (-2.54%) ⬇️
.../processors/CheckExpiredMutingsProcessorService.ts 95.65% <ø> (-2.35%) ⬇️
...kend/src/queue/processors/CleanProcessorService.ts 51.94% <ø> (-2.38%) ⬇️
... and 97 more

... and 16 files with indirect coverage changes

@syuilo syuilo merged commit 8a6791d into misskey-dev:develop Aug 5, 2023
19 checks passed
@syuilo
Copy link
Member

syuilo commented Aug 5, 2023

👍🏻

@woxtu woxtu deleted the unused-injections branch August 6, 2023 04:02
anatawa12 pushed a commit to anatawa12/misskey that referenced this pull request Aug 16, 2023
* Remove unused injections

* Remove unused imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

使わないDIを消去
2 participants