Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update & fix dependencies #3450

Merged
merged 1 commit into from Oct 5, 2019
Merged

update & fix dependencies #3450

merged 1 commit into from Oct 5, 2019

Conversation

alexlamsl
Copy link
Collaborator

No description provided.

@alexlamsl alexlamsl merged commit bde7418 into mishoo:master Oct 5, 2019
@alexlamsl alexlamsl deleted the deps branch October 5, 2019 19:10
@XhmikosR
Copy link
Contributor

XhmikosR commented Oct 8, 2019

Why did you lock commander to 2.20.0 @alexlamsl?

@alexlamsl
Copy link
Collaborator Author

Because 2.20.1 was causing Travis CI to fail, and they don't plan on updating 2.x any further.

@XhmikosR
Copy link
Contributor

XhmikosR commented Oct 9, 2019

I don't see how this can be true. They didn't touch the dependencies, only devDependencies.

tj/commander.js@v2.20.0...v2.20.1

@L2jLiga
Copy link

L2jLiga commented Oct 10, 2019

@XhmikosR they change {} with Set which is not supported by node.js 0.10, node 0.10 specified in .travis.yml and that causing CI to fail

@XhmikosR
Copy link
Contributor

Right. I couldn't even imagine there would be someone still supporting Node.js 0.10.

@XhmikosR
Copy link
Contributor

@alexlamsl please change back to a semver range to allow package managers to flatten the deps tree. commander 2.20.3 is out which revert the Set change.

But you should drop 0.10 support. It's 2019.

@alexlamsl
Copy link
Collaborator Author

@XhmikosR thanks for the heads up - will test and update.

And it's not the first time you and I have fundamental differences on the concept of compatibility, so thanks again for your opinion but Node.js 0.10 is here to stay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants