Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require: statically require modules so you can webpack #3432

Closed
wants to merge 1 commit into from
Closed

require: statically require modules so you can webpack #3432

wants to merge 1 commit into from

Conversation

stevenschlansker
Copy link

@stevenschlansker stevenschlansker commented Jul 1, 2019 •
edited

Webpack has difficulties evaluating dynamic require statements.
UglifyJS does not actually need dynamic requires - so replace them with static require.

Fixes #2115

@stevenschlansker stevenschlansker mentioned this pull request Jul 1, 2019
Closed
@alexlamsl
Copy link
Collaborator

I just noticed this is the same as #3435 which I've just merged. Thanks anyway!

@alexlamsl alexlamsl closed this Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Critical dependency: the request of a dependency is an expression
2 participants
@stevenschlansker @alexlamsl