fix corner case in assignments (#3430)

fixes #3429
mishoo · May 29, 2019 · 9d3b1ef · 9d3b1ef
1 parent 482e1ba
commit 9d3b1ef
Show file tree

Hide file tree

Showing 2 changed files with 47 additions and 1 deletion.
diff --git a/lib/compress.js b/lib/compress.js
@@ -3856,7 +3856,7 @@ merge(Compressor.prototype, {
             if (!(rhs instanceof AST_Binary && lazy_op[rhs.operator])) return rhs;
             var sym = assign.left;
             if (!(sym instanceof AST_SymbolRef) || sym.name != rhs.left.name) return rhs;
-            return rhs.right;
+            return rhs.right.has_side_effects(compressor) ? rhs : rhs.right;
         }
 
         function scan_ref_scoped(node, descend) {

diff --git a/test/compress/assignment.js b/test/compress/assignment.js
@@ -327,3 +327,49 @@ issue_3427: {
     }
     expect: {}
 }
+
+issue_3429_1: {
+    options = {
+        assignments: true,
+        side_effects: true,
+        unused: true,
+    }
+    input: {
+        var a = "PASS";
+        (function(b) {
+            b && (b = a = "FAIL");
+        })();
+        console.log(a);
+    }
+    expect: {
+        var a = "PASS";
+        (function(b) {
+            b = b && (a = "FAIL");
+        })();
+        console.log(a);
+    }
+    expect_stdout: "PASS"
+}
+
+issue_3429_2: {
+    options = {
+        assignments: true,
+        side_effects: true,
+        unused: true,
+    }
+    input: {
+        var a;
+        (function(b) {
+            b || (b = a = "FAIL");
+        })(42);
+        console.log(a);
+    }
+    expect: {
+        var a;
+        (function(b) {
+            b = b || (a = "FAIL");
+        })(42);
+        console.log(a);
+    }
+    expect_stdout: "undefined"
+}