Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock starlette requirement at <1.0 #961

Merged
merged 3 commits into from Nov 3, 2022
Merged

Lock starlette requirement at <1.0 #961

merged 3 commits into from Nov 3, 2022

Conversation

rafalp
Copy link
Contributor

@rafalp rafalp commented Nov 2, 2022

Changes starlette requirement in setup.py to <1.0 so Ariadne will not complain about unsupported Starlette's version.

We are using Starlette mostly for handling ASGI requests, so 🤞 future version will not break our use case.

Fixes #956

@rafalp rafalp added this to the Ariadne 0.17 milestone Nov 2, 2022
@rafalp rafalp requested a review from mat-sop November 2, 2022 15:09
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #961 (8406883) into master (7a19ee1) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #961      +/-   ##
==========================================
- Coverage   98.13%   98.10%   -0.04%     
==========================================
  Files         109      111       +2     
  Lines        6716     6742      +26     
==========================================
+ Hits         6591     6614      +23     
- Misses        125      128       +3     
Impacted Files Coverage Δ
tests/asgi/test_query_execution.py 97.77% <ø> (-1.12%) ⬇️
tests/wsgi/snapshots/snap_test_explorer.py 100.00% <ø> (ø)
ariadne/explorer/__init__.py 100.00% <100.00%> (ø)
ariadne/explorer/apollo.py 100.00% <100.00%> (ø)
ariadne/explorer/default_query.py 100.00% <100.00%> (ø)
ariadne/explorer/graphiql.py 100.00% <100.00%> (ø)
tests/asgi/snapshots/snap_test_explorer.py 100.00% <100.00%> (ø)
tests/asgi/test_http_methods.py 100.00% <100.00%> (ø)
tests/asgi/test_request_data_reading.py 100.00% <100.00%> (ø)
tests/explorers/snapshots/snap_test_explorers.py 100.00% <100.00%> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rafalp rafalp changed the title Bump starlette support to 0.21 Lock starlette requirement at <1.0 Nov 2, 2022
@rafalp rafalp merged commit 8af6377 into master Nov 3, 2022
@rafalp rafalp deleted the update-starlette branch November 3, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Starlette 0.21.0
2 participants