Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Starlette 0.21.0 #956

Closed
adriangarrote opened this issue Oct 27, 2022 · 4 comments · Fixed by #961
Closed

Support Starlette 0.21.0 #956

adriangarrote opened this issue Oct 27, 2022 · 4 comments · Fixed by #961
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@adriangarrote
Copy link

Starlette 0.21.0 fix important issues on the BaseHttpMiddleware side.

encode/starlette#1715
tiangolo/fastapi#4544

@rafalp rafalp self-assigned this Nov 2, 2022
@rafalp rafalp added this to the Ariadne 0.17 milestone Nov 2, 2022
@rafalp rafalp added the enhancement New feature or request label Nov 2, 2022
@rafalp
Copy link
Contributor

rafalp commented Nov 2, 2022

I am thinking that we should set Starlette dependency in Ariadne at <1.0. I don't remember Starlette's release in recent years that broke Ariadne, seeing how its used in ASGI GraphQL app for parsing ASGI request.

This would spare us the need for new release every time Starlette releases new 0.X version.

@aklim007
Copy link

@rafalp Please release with this fix, it blocks the fastapi update in my project.

@rafalp
Copy link
Contributor

rafalp commented Dec 9, 2022

@aklim007 Noted, next week I'll make 0.17 release that is branched from 0.16.1 release and bumps starlette dependency to <1.0 and I'll make current work on master target 0.18 release instead.

@rafalp
Copy link
Contributor

rafalp commented Dec 13, 2022

Beta release is up on PyPi: 0.17.0b2

I'll test it against few projects and if things seem to be ok, I'll release stable 0.17 tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants