Updates typing for Request.queryParams
#1027
Conversation
This uses the type from https://github.com/tildeio/route-recognizer/blob/0a44fd86081ef425071839d3184e72fd2916d6fe/lib/route-recognizer.ts#L432 / https://github.com/tildeio/route-recognizer/blob/0a44fd86081ef425071839d3184e72fd2916d6fe/lib/route-recognizer.ts#L454 I think that https://github.com/tildeio/route-recognizer/blob/0a44fd86081ef425071839d3184e72fd2916d6fe/lib/route-recognizer.ts#L161 might contain the correct type for `params` a la miragejs#1026 but that seems to need better verification
|
@jasikpark could you force-push to this branch to trigger a new run? I'm curious if it will still fail, and I can't trigger a re-run (maybe it's too old) |
|
@IanVS mind approving the CI run? |
|
@cah-brian-gantzler how will we handle types when we swap out MSW for pretender? For instance, in this PR, we can see that the If one were to swap out MSW, would the types here change, I guess? |
|
thx for the approval! i don't have merge perms, so merge when you think it's ready to be |
|
@IanVS |
|
so this can merge then? |
|
I am ok with this being merged |
|
mind clicking the button for me then? I don't have the permissions for merging my own PR |
|
I will do it in a minute after giving one more quick look. |
Yes, but the fake |
|
If you find anything out would be interested |
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [miragejs](https://togithub.com/miragejs/miragejs) | [`^0.1.47` -> `^0.1.48`](https://renovatebot.com/diffs/npm/miragejs/0.1.47/0.1.48) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>miragejs/miragejs (miragejs)</summary> ### [`v0.1.48`](https://togithub.com/miragejs/miragejs/releases/tag/v0.1.48) [Compare Source](https://togithub.com/miragejs/miragejs/compare/v0.1.47...v0.1.48) #### What's Changed 🚀 **Enhancements** - Add Middleware support via `server.middleware = [/*...*/]` by [@​osi-jehrlich](https://togithub.com/osi-jehrlich) in [miragejs/miragejs#1089 - Allow for keyForId and valueForId on the serializer by [@​cah-brian-gantzler](https://togithub.com/cah-brian-gantzler) in [miragejs/miragejs#1086 🐛 **Bugfixes** - Don't require testConfig for timing to respect environment. by [@​rmjohnson-olo](https://togithub.com/rmjohnson-olo) in [miragejs/miragejs#1080 - Update typing for `Request.queryParams` by [@​jasikpark](https://togithub.com/jasikpark) in [miragejs/miragejs#1027 🏠 **Internal** - Simplify lodash dependencies by [@​mansona](https://togithub.com/mansona) in [miragejs/miragejs#1091 #### New Contributors - [@​jasikpark](https://togithub.com/jasikpark) made their first contribution in [miragejs/miragejs#1027 - [@​rmjohnson-olo](https://togithub.com/rmjohnson-olo) made their first contribution in [miragejs/miragejs#1080 - [@​osi-jehrlich](https://togithub.com/osi-jehrlich) made their first contribution in [miragejs/miragejs#1089 **Full Changelog**: miragejs/miragejs@v0.1.47...v0.1.48 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 5am every weekday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/magicbell-io/magicbell-js). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
This uses the type from https://github.com/tildeio/route-recognizer/blob/0a44fd86081ef425071839d3184e72fd2916d6fe/lib/route-recognizer.ts#L432 / https://github.com/tildeio/route-recognizer/blob/0a44fd86081ef425071839d3184e72fd2916d6fe/lib/route-recognizer.ts#L454
I think that https://github.com/tildeio/route-recognizer/blob/0a44fd86081ef425071839d3184e72fd2916d6fe/lib/route-recognizer.ts#L161 might contain the correct type for
paramsa la #1026 but that seems to need better verification