[Fix]: fix prop-types Cannot read property 'type' of undefined erro…

…r when destructured param see jsx-eslint#2805, jsx-eslint#2804, jsx-eslint#2805 (comment)
minwe · Sep 27, 2020 · d75c555 · d75c555
1 parent 4589522
commit d75c555
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 2 deletions.
diff --git a/lib/rules/prop-types.js b/lib/rules/prop-types.js
@@ -150,7 +150,7 @@ module.exports = {
           return;
         }
         param.properties.forEach((property) => {
-          if (property.type === 'RestElement') {
+          if (property.type === 'RestElement' || property.type === 'ExperimentalRestProperty') {
             return;
           }
           const type = property.value.type;

diff --git a/tests/lib/rules/prop-types.js b/tests/lib/rules/prop-types.js
@@ -3096,7 +3096,7 @@ ruleTester.run('prop-types', rule, {
           )
         }
 
-        const mapDispatchToProps = (dispatch: ThunkDispatch<State, null, Action>) => 
+        const mapDispatchToProps = (dispatch: ThunkDispatch<State, null, Action>) =>
           bindActionCreators<{prop1: ()=>void,prop2: ()=>string}>(
             { prop1: importedAction, prop2: anotherImportedAction },
             dispatch,
@@ -6163,6 +6163,28 @@ ruleTester.run('prop-types', rule, {
         errors: [{
           message: "'bar' is missing in props validation"
         }]
+      },
+      // fix #2804
+      {
+        code: `
+        import React from 'react'
+
+        const InputField = ({ type, ...restProps }) => {
+
+          return(
+            <input
+              type={type}
+              {...restProps}
+            />
+          )
+        }
+
+        export default InputField;
+      `,
+        parser: parsers.BABEL_ESLINT,
+        errors: [{
+          message: "'type' is missing in props validation"
+        }]
       }
     ])
   )