This repository has been archived by the owner on Jun 7, 2022. It is now read-only.
Update Go and package dependencies #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go updated to 1.18 Packages updated to the lastes versions for each. Upgrading `github.com/prometheus/common` encountered the breaking change in which removed the Log package (prometheus/common#306), so the logging code has also been updated to use promlog instead. Mitigates security issues: GJSON before 1.6.4 allows attackers to cause a denial of service via crafted JSON. https://nvd.nist.gov/vuln/detail/CVE-2020-35380 GJSON <1.6.5 allows attackers to cause a denial of service (remote) via crafted JSON. https://nvd.nist.gov/vuln/detail/CVE-2020-36066 GJSON <=v1.6.5 allows attackers to cause a denial of service (panic: runtime error: slice bounds out of range) via a crafted GET call. https://nvd.nist.gov/vuln/detail/CVE-2020-36067 GJSON before 1.9.3 allows a ReDoS (regular expression denial of service) attack. https://nvd.nist.gov/vuln/detail/CVE-2021-42836 The x/text package before 0.3.3 for Go has a vulnerability in encoding/unicode that could lead to the UTF-16 decoder entering an infinite loop, causing the program to crash or run out of memory. An attacker could provide a single byte to a UTF16 decoder instantiated with UseBOM or ExpectBOM to trigger an infinite loop if the String function on the Decoder is called, or the Decoder is passed to golang.org/x/text/transform.String. https://nvd.nist.gov/vuln/detail/CVE-2020-14040
|
Thanks for the PR @RoryCrispin. We don't actually use this anymore and have no way to test it so I'm going to assume this is all good to merge and then archive the repo! |
bcbrockway
approved these changes
Jun 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go updated to 1.18
Packages updated to the lastes versions for each.
Upgrading
github.com/prometheus/commonencountered the breaking change inwhich removed the Log package (prometheus/common#306),
so the logging code has also been updated to use promlog instead.
Mitigates security issues:
GJSON before 1.6.4 allows attackers to cause a denial of service via crafted JSON.
https://nvd.nist.gov/vuln/detail/CVE-2020-35380
GJSON <1.6.5 allows attackers to cause a denial of service (remote) via crafted JSON.
https://nvd.nist.gov/vuln/detail/CVE-2020-36066
GJSON <=v1.6.5 allows attackers to cause a denial of service (panic: runtime error: slice bounds out of range) via a crafted GET call.
https://nvd.nist.gov/vuln/detail/CVE-2020-36067
GJSON before 1.9.3 allows a ReDoS (regular expression denial of service) attack.
https://nvd.nist.gov/vuln/detail/CVE-2021-42836
The x/text package before 0.3.3 for Go has a vulnerability in encoding/unicode that could lead to the UTF-16 decoder entering an infinite loop, causing the program to crash or run out of memory. An attacker could provide a single byte to a UTF16 decoder instantiated with UseBOM or ExpectBOM to trigger an infinite loop if the String function on the Decoder is called, or the Decoder is passed to golang.org/x/text/transform.String.
https://nvd.nist.gov/vuln/detail/CVE-2020-14040