馃敤 - Update Accounts Endpoint #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrooney
previously approved these changes
Mar 28, 2022
|
Approved although it looks like black ran into an error 馃 |
burkematthew
force-pushed
the
chore/update-accounts-endpoint
branch
from
3d38ad5
to
a4c4b82
Compare
|
@mrooney just FYI, the issue we're seeing with black should be fixed when this patch is released: psf/black#2966 |
|
All good now! |
burkematthew
force-pushed
the
chore/update-accounts-endpoint
branch
from
a4c4b82
to
bbfc1cf
Compare
mrooney
approved these changes
Mar 29, 2022
|
Is there any info on what we'll lose without Update: I think one of the things was banks also having |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the outdated Accounts endpoint with the switch to the new Mint UI. For v1 of this update, we are going to keep the formatting as is returned from the API, except we are popping out the metadata so that each element can be flattened for a CSV.
Note that there is NO LONGER an
extended-accountsfunctionality. This functionality was a nasty workaround that involved scrapping div elements off the screen. Considering that the majority of the data is already in the response and that the UI changed, Mintapi will no longer attempt to pull data in this fashion.