Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes popups after test finishes (shared strategy) #135

Merged

Conversation

aik099
Copy link
Member

@aik099 aik099 commented Apr 7, 2024

Now the popups, that test have opened are closed before starting the next test in the same test case class.

Copy link

codecov bot commented Apr 7, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 82.85%. Comparing base (7142faa) to head (6f7c188).

Files Patch % Lines
...y/aik099/PHPUnit/Session/SharedSessionStrategy.php 62.50% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #135      +/-   ##
============================================
- Coverage     86.29%   82.85%   -3.44%     
- Complexity      329      331       +2     
============================================
  Files            29       29              
  Lines           868      875       +7     
============================================
- Hits            749      725      -24     
- Misses          119      150      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aik099 aik099 merged commit 126c515 into minkphp:master Apr 7, 2024
10 of 12 checks passed
@aik099 aik099 deleted the shared-session-strategy-popup-closing branch April 7, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant