Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing deprecations #38

Closed
wants to merge 1 commit into from
Closed

Conversation

oleg-andreyev
Copy link
Contributor

Changes that are required for minkphp/MinkBrowserKitDriver#138

@aik099
Copy link
Member

aik099 commented Sep 6, 2019

I'm not sure how symfony/symfony#33236 works, but it on Travis CI somehow (maybe based on PHP version) is patching PHP files to that they'll have correct return types for overridden methods.

I like the idea, because this way we don't need to create IFs by PHP versions and different PHP classes for same thing with different method declarations.

@stof , if you like the patching idea in general, then we can start with simple sed command without actually:

  1. parsing PHP file into tokens
  2. adding tokens in the middle
  3. saving resulted file

This way if declaration is changed in the future the build would immediately fail with same deprecation notice (since sed failed to make a replace). Then (if by that time we'll remember that sed is saving the day) we'll need to fix expression used in it.

@stof
Copy link
Member

stof commented Sep 6, 2019

I suggest discussing minkphp/Mink#787 before moving forward, as this will impact the way we solve things.

@stof
Copy link
Member

stof commented Jan 19, 2022

Closing in favor of #54 which is a lot simpler thanks to the ability to support only PHP 7.2+

@stof stof closed this Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants