Fix U21 matches not being recognised for xp calc #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Similar tests are "reversed", does |
Sure, we could do it that way.
I'll see if I can figure out how update the PR. |
The updated code in function getNTType() wasn't catching U21 continental cup matches.
unnecessarydave
force-pushed
the
bugfix/player-stats-experience
branch
from
5af9630
to
d505fca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updated code in function getGameType wasn't catching U21 continental cup matches. Adding the relevant icon names to the CONT_CUPS list fixes this.