Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDLS-224 : Add a check for submitted reports in report review page #1590

Merged
merged 1 commit into from
May 16, 2024

Conversation

ndasmoj
Copy link
Contributor

@ndasmoj ndasmoj commented May 15, 2024

Purpose

Fixes DDLS-224

Approach

The review page of a report checks if there are documents attached to the report which are quite old and not available in S3 anymore. In such a scenario, the system asks the user to reupload the documents. The logic did not filter submitted reports. This fix adds a check to see if the report is submitted and if it is, then the logic is ignored.

Learning

Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about DigiDeps

Checklist

  • I have performed a self-review of my own code
  • I have updated documentation (Confluence/ADR/tech debt doc) where relevant
  • I have added tests to prove my work
  • The product team have approved these changes
  • I have checked my work for potential security issues and refered to the OWASP top 10

Frontend

  • I have run an in-browser accessibility test (e.g. WAVE, Lighthouse)
  • There are no deprecated CSS classes noted in the profiler
  • Translations are used and the profiler doesn't identify any missing
  • Any links or buttons added are screen reader friendly and contextually complete
  • If adding GA events, I have updated or checked the existing category or label values

@ndasmoj ndasmoj marked this pull request as ready for review May 15, 2024 10:47
@ndasmoj ndasmoj requested a review from a team as a code owner May 15, 2024 10:47
@ndasmoj ndasmoj merged commit 7947def into main May 16, 2024
37 checks passed
@ndasmoj ndasmoj deleted the DDLS-224 branch May 16, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants