-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDLS-186 v2 Rename named_deputy to deputy #1589
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In order to reduce the confusion surrounding what a named deputy is (which is no different to any other deputy on the order), we should rename the named_deputy table to deputy .
We should also rename the reference column in the client table which refers to it as named_deputy_id to deputy_id. If possible, we should also update the getters and setters for this and drop the named wording.
Acceptance Criteria:
named_deputy table is called deputy table
Alter doctrine annotations to new name
client.named_deputy_id is now called client.deputy_id
Getters and setters are also updated accordingly
Update any sql queries which directly reference the named_deputy table
Fixes DDLS-186
Approach
Added migration to make database changes
Changed class names containing named to deputy only
Changed variable named containg named to deputy only
Prof and PA named deputy have not been changed
Learning
Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about DigiDeps
Checklist
Frontend