Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDLS-186 v2 Rename named_deputy to deputy #1589

Merged
merged 27 commits into from
May 20, 2024
Merged

DDLS-186 v2 Rename named_deputy to deputy #1589

merged 27 commits into from
May 20, 2024

Conversation

iqpalm
Copy link
Contributor

@iqpalm iqpalm commented May 14, 2024

Purpose

In order to reduce the confusion surrounding what a named deputy is (which is no different to any other deputy on the order), we should rename the named_deputy table to deputy .

We should also rename the reference column in the client table which refers to it as named_deputy_id to deputy_id. If possible, we should also update the getters and setters for this and drop the named wording.

Acceptance Criteria:

named_deputy table is called deputy table

Alter doctrine annotations to new name

client.named_deputy_id is now called client.deputy_id

Getters and setters are also updated accordingly

Update any sql queries which directly reference the named_deputy table

Fixes DDLS-186

Approach

Added migration to make database changes
Changed class names containing named to deputy only
Changed variable named containg named to deputy only
Prof and PA named deputy have not been changed

Learning

Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about DigiDeps

Checklist

  • I have performed a self-review of my own code
  • I have updated documentation (Confluence/ADR/tech debt doc) where relevant
  • I have added tests to prove my work
  • The product team have approved these changes
  • I have checked my work for potential security issues and refered to the OWASP top 10

Frontend

  • I have run an in-browser accessibility test (e.g. WAVE, Lighthouse)
  • There are no deprecated CSS classes noted in the profiler
  • Translations are used and the profiler doesn't identify any missing
  • Any links or buttons added are screen reader friendly and contextually complete
  • If adding GA events, I have updated or checked the existing category or label values

@iqpalm iqpalm marked this pull request as ready for review May 16, 2024 09:05
@iqpalm iqpalm requested a review from a team as a code owner May 16, 2024 09:05
@iqpalm iqpalm merged commit 19cd9a6 into main May 20, 2024
37 checks passed
@iqpalm iqpalm deleted the DDLS-186-2 branch May 20, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants