Manually update rails-html-sanitizer gem #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have started to see deprecation warnings whilst running specs, specifically "DEPRECATION WARNING: warning: white_list_sanitizer isdeprecated, please use safe_list_sanitizer instead." An issue was opened on the Rails Github account (rails/rails#36858) and basically the fix is to update to the latest version of the gem. However, we have reduced the frequency we are getting Dependabot updates and it could be another couple of weeks before this particular update comes through, and therefore thought it would be a good idea to just update it manually so we can stop seeing the deprecation warning.
theKHutDeveloper
approved these changes
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have started to see deprecation warnings whilst running specs,
specifically "DEPRECATION WARNING: warning: white_list_sanitizer
isdeprecated, please use safe_list_sanitizer instead." An issue was
opened on the Rails Github account
(rails/rails#36858) and basically the fix is
to update to the latest version of the gem.
However, we have reduced the frequency we are getting Dependabot updates
and it could be another couple of weeks before this particular update
comes through, and therefore thought it would be a good idea to just
update it manually so we can stop seeing the deprecation warning.