fix(filter-toggle-button): make bigModeMediaQuery optional
#412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if `bigModeMediaQuery` isn't set then the component will always initialise in "small" mode, where the filter bar is hidden, even if `startHidden` is set to false or not specified. This change makes `bigModeMediaQuery` optional so that, if it isn't set, `startHidden` is adhered to. `bigModeMediaQuery` still takes priority over `startHidden` if both are set. BREAKING CHANGE: If you specify neither `bigModeMediaQuery` nor `startHidden`, the filter will now be initially open on larger screens. To avoid this behaviour, add the `startHidden: true` property.
gregtyler
added
staging:request
|
🚀 Deploying to staging environment |
github-actions
bot
added
staging:active
github-actions
bot
removed
the
staging:active
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if
bigModeMediaQueryisn't set then the component will always initialise in "small" mode, where the filter bar is hidden, even ifstartHiddenis set to false or not specified.This change makes
bigModeMediaQueryoptional so that, if it isn't set,startHiddenis adhered to.bigModeMediaQuerystill takes priority overstartHiddenif both are set.BREAKING CHANGE: If you specify neither
bigModeMediaQuerynorstartHidden, the filter will now be initially open on larger screens. To avoid this behaviour, add thestartHidden: trueproperty.