[CRIMAP-687] evidence download failure logging #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiboabd
commented
Oct 31, 2023
| @@ -29,7 +29,7 @@ | |||
| config.cache_store = :null_store | |||
|
|
|||
| # Raise exceptions instead of rendering exception templates. | |||
| config.action_dispatch.show_exceptions = true | |||
| config.action_dispatch.show_exceptions = :all | |||
There was a problem hiding this comment.
Fixes a warning that appeared following an upgrade to rails: Setting action_dispatch.show_exceptions to true is deprecated. Set to :all instead.
There is another warning that I believe will be fixed by devise
mseedat-moj
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Follows PR in apply to add logging around evidence upload failures. The logs capture user id, ip address, severity (error), file type and s3 object key information.
Also adds some error handling to display a message to the user if a download attempt failed. This follows an existing pattern for failures around evidence deletion currently implemented in apply. A screenshot is attached below.
Link to relevant ticket
CRIMAP-687
Notes for reviewer
Note: There is logging already in place in the datastore handling errors with calls to obtain the presign download url. By adding logging on review, we can collect additional information we are interested in e.g. who is attempting to download that wouldn't be available to us in the datastore.
Screenshots of changes (if applicable)
Before changes:
After changes:
How to manually test the feature