Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warnings on white_list_sanitizer #732

Closed
wants to merge 0 commits into from

Conversation

mpw5
Copy link
Contributor

@mpw5 mpw5 commented Aug 12, 2019

What

The recent update to v1.1.0 of rails_html_sanitizer means that rspec is raising lots of unnecessary deprecation warnings. This is a bug in that version and and is resolved by updating to v1.2.0.

See issue and suggested fix here: rails/rails#36858

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase master.
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against master and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@mpw5 mpw5 added the ready for review Please review label Aug 12, 2019
@mpw5 mpw5 force-pushed the fix-white_list_sanitizer-deprecation branch from d47bfb4 to 4e9e668 Compare August 12, 2019 10:02
@mpw5 mpw5 closed this Aug 12, 2019
@mpw5 mpw5 force-pushed the fix-white_list_sanitizer-deprecation branch from 4e9e668 to d0ec2e0 Compare August 12, 2019 13:31
@mpw5 mpw5 deleted the fix-white_list_sanitizer-deprecation branch August 15, 2019 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Please review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants