Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: update proceeding loop spacing #6686

Merged
merged 1 commit into from
May 16, 2024

Conversation

agoldstone93
Copy link
Contributor

@agoldstone93 agoldstone93 commented May 16, 2024

What

Remove custom spacing so default spacing is used on the substantive_defaults and delegated_functions pages
Agreed with designers

Screenshots

image image

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@agoldstone93 agoldstone93 force-pushed the chore-update-proceeding-loop-spacing branch from 9b79a05 to f40746b Compare May 16, 2024 13:31
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@agoldstone93 agoldstone93 marked this pull request as ready for review May 16, 2024 13:53
@agoldstone93 agoldstone93 requested a review from a team as a code owner May 16, 2024 13:53
@agoldstone93 agoldstone93 merged commit 9300097 into main May 16, 2024
14 checks passed
@agoldstone93 agoldstone93 deleted the chore-update-proceeding-loop-spacing branch May 16, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants