Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP-5021: Add linked applications info to review and print page and submitted applications page #6685

Merged
merged 6 commits into from
May 22, 2024
Merged

AP-5021: Add linked applications info to review and print page and submitted applications page #6685

merged 6 commits into from
May 22, 2024

Conversation

agoldstone93
Copy link
Contributor

@agoldstone93 agoldstone93 commented May 16, 2024 •
edited

What

Link to story

Add linked applications info to review and print page and submitted applications page
Add existing code to partial

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@agoldstone93 agoldstone93 force-pushed the ap-5021-add-link-and-copy-information-to-review-and-print-page branch from d40f7f2 to d375b09 Compare May 16, 2024 13:18
@agoldstone93 agoldstone93 marked this pull request as ready for review May 16, 2024 13:19
@agoldstone93 agoldstone93 requested a review from a team as a code owner May 16, 2024 13:19
colinbruce
colinbruce approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@colinbruce colinbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, one non-blocking question about the locale entries

config/locales/en/shared.yml Show resolved Hide resolved
@agoldstone93 agoldstone93 force-pushed the ap-5021-add-link-and-copy-information-to-review-and-print-page branch from d375b09 to 450feef Compare May 16, 2024 13:44
kmahern
kmahern reviewed May 16, 2024
View reviewed changes
app/views/shared/check_answers/_linking_and_copying.html.erb
@@ -0,0 +1,81 @@
<% read_only = false unless local_assigns.key?(:read_only) %>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could any of these changes be added to review_and_print.feature?

@agoldstone93 agoldstone93 force-pushed the ap-5021-add-link-and-copy-information-to-review-and-print-page branch 2 times, most recently from befc3ad to 33b7a18 Compare May 20, 2024 12:49
@agoldstone93 agoldstone93 requested a review from kmahern May 20, 2024 12:59
kmahern
kmahern reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@kmahern kmahern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

kmahern
kmahern approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@kmahern kmahern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@kmahern kmahern self-requested a review May 20, 2024 14:14
kmahern
kmahern approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@kmahern kmahern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@agoldstone93 agoldstone93 force-pushed the ap-5021-add-link-and-copy-information-to-review-and-print-page branch from 2dad7d9 to f7ceb11 Compare May 21, 2024 08:34
colinbruce
colinbruce approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@colinbruce colinbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@agoldstone93 agoldstone93 force-pushed the ap-5021-add-link-and-copy-information-to-review-and-print-page branch from ed07451 to 153983b Compare May 22, 2024 08:21
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@agoldstone93 agoldstone93 merged commit 3c770d3 into main May 22, 2024
14 checks passed
@agoldstone93 agoldstone93 deleted the ap-5021-add-link-and-copy-information-to-review-and-print-page branch May 22, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinbruce colinbruce colinbruce approved these changes

@kmahern kmahern kmahern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@agoldstone93 @colinbruce @kmahern