Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ap-5023: add merits task list to cloner service #6683

Merged
merged 2 commits into from
May 21, 2024

Conversation

kmahern
Copy link
Contributor

@kmahern kmahern commented May 16, 2024

What

Link to story

Added legal_framework_merits_task_list to ClonerService
Resolved TODO (removed guard clause to obtain legal_framework_merits_task_list from copied application if copy_case == true)

Describe what you did and why.

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@kmahern kmahern force-pushed the ap-5023-add-merits-task-list-to-cloner branch 3 times, most recently from fa6504e to a2d154d Compare May 16, 2024 14:55
@kmahern kmahern force-pushed the ap-5023-add-merits-task-list-to-cloner branch from a2d154d to 8751fcc Compare May 20, 2024 09:28
Copy link

sonarcloud bot commented May 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kmahern kmahern marked this pull request as ready for review May 20, 2024 10:10
@kmahern kmahern requested a review from a team as a code owner May 20, 2024 10:10
Copy link
Contributor

@agoldstone93 agoldstone93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agoldstone93 agoldstone93 added the approved Approved by code reviewers label May 20, 2024
@kmahern kmahern merged commit b02658e into main May 21, 2024
14 checks passed
@kmahern kmahern deleted the ap-5023-add-merits-task-list-to-cloner branch May 21, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved by code reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants