Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP-5005: Implement cloner service #6671

Merged
merged 3 commits into from
May 17, 2024
Merged

AP-5005: Implement cloner service #6671

merged 3 commits into from
May 17, 2024

Conversation

colinbruce
Copy link
Contributor

@colinbruce colinbruce commented May 14, 2024 •
edited

What

Link to story

This implements a call to the cloner service when the provider clicks continue on the Check Provider Answers page
It also deletes the lead_linked_application object if the provider has selected no to linking or changed their mind on the confirm_link page

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@colinbruce colinbruce force-pushed the ap-5005/implement-cloner-service branch 3 times, most recently from 280ff05 to 89165cc Compare May 15, 2024 08:23
@colinbruce colinbruce marked this pull request as ready for review May 15, 2024 08:41
@colinbruce colinbruce requested a review from a team as a code owner May 15, 2024 08:41
@colinbruce colinbruce added the ready for review Please review label May 15, 2024
kmahern
kmahern approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@kmahern kmahern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colinbruce colinbruce force-pushed the ap-5005/implement-cloner-service branch from 89165cc to 3fdec25 Compare May 16, 2024 07:56
@colinbruce
AP-5005: Update legal_aid_application database table
186b176 
Change the no-longer used link_case filed to case_cloned

This should allow us to track the cloner being run and
prevent it being run multiple times
@colinbruce
AP-5005: Update check_provider_answers_controller to call cloner
a9c1e8c
@colinbruce
AP-5005: Update feature step removing link_case use
2e6dfc1 
This field has been removed and is no longer tracked
or used so updating it is superfluous
@colinbruce colinbruce force-pushed the ap-5005/implement-cloner-service branch from 3fdec25 to 2e6dfc1 Compare May 16, 2024 13:00
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@colinbruce colinbruce merged commit c1c3031 into main May 17, 2024
14 checks passed
@colinbruce colinbruce deleted the ap-5005/implement-cloner-service branch May 17, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmahern kmahern kmahern approved these changes

Assignees
No one assigned
Labels
ready for review Please review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@colinbruce @kmahern