Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-4670-flow-refactoring-provider-dependants #6663

Merged
merged 4 commits into from
May 21, 2024

Conversation

skdejong
Copy link
Contributor

What

Flow refactoring - provider_dependants flow

Describe what you did and why.

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@skdejong skdejong added the WIP Work In Progress label May 13, 2024
@skdejong skdejong force-pushed the ap-4670-flow-refactoring-provider-dependants branch 4 times, most recently from b1d927e to cded484 Compare May 16, 2024 12:52
@skdejong skdejong force-pushed the ap-4670-flow-refactoring-provider-dependants branch from cded484 to 7924872 Compare May 20, 2024 08:10
Copy link

sonarcloud bot commented May 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@skdejong skdejong added ready for review Please review and removed WIP Work In Progress labels May 20, 2024
@skdejong skdejong marked this pull request as ready for review May 20, 2024 14:41
@skdejong skdejong requested a review from a team as a code owner May 20, 2024 14:41
Copy link
Contributor

@kmahern kmahern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@colinbruce colinbruce added Ready to merge Has passed UAT testing and can be merged into master and removed ready for review Please review labels May 21, 2024
@skdejong skdejong merged commit c1c0cf5 into main May 21, 2024
14 checks passed
@skdejong skdejong deleted the ap-4670-flow-refactoring-provider-dependants branch May 21, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge Has passed UAT testing and can be merged into master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants