Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP1540 Accessibility fix for Savings and Investments and other assets page #1662

Merged
merged 2 commits into from
Aug 14, 2020
Merged

AP1540 Accessibility fix for Savings and Investments and other assets page #1662

merged 2 commits into from
Aug 14, 2020

Commits on Aug 14, 2020

  1. Fix accessibility issues 

    Add the aria-describedby id to the select_all_that_apply field as it broke WAVE testing of aria tags for the savings and investments page and other assets page.

Fix duplication of error messages under the select_all_that_apply hint because it's already in the error summary above the title. This is only when checkboxes are checked and nested values cause an error on submission. It still shows an error underneath it for when no checkboxes were selected validation fails

Test the above. However, keep an eye on rspec/rspec-expectations#1168
which is an rspec matcher coming soon that allows to test how many times something has been seen in a response body.
    @Obsiye
    Obsiye committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    1b2d184 View commit details
    Browse the repository at this point in the history

  2. Standardise select-all-that-apply to a span tag govuk-hint 

    Standardise select-all-that-apply-hint to be a hint and not a heading tag
    @Obsiye
    Obsiye committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    5d6fd44 View commit details
    Browse the repository at this point in the history