Skip to content

Commit

Permalink
Standardise select-all-that-apply to a span tag govuk-hint
Browse files Browse the repository at this point in the history
Standardise select-all-that-apply-hint to be a hint and not a heading tag
  • Loading branch information
Obsiye committed Aug 12, 2020
1 parent 40d1166 commit d7239e1
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion app/views/shared/forms/_offline_accounts_form.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<%= govuk_form_group show_error_if: @form.errors.present? do %>
<fieldset class="govuk-fieldset" aria-describedby="select-all-that-apply-hint">
<%= govuk_fieldset_header page_title %>
<h2 class="govuk-heading-m"><%= t('generic.select_all_that_apply') %></h2>
<span id="select-all-that-apply-hint" class="govuk-hint"><%= t('generic.select_all_that_apply') %></span>

<%= render 'shared/show_errors' %>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<%= govuk_form_group show_error_if: @form.errors.present? do %>
<fieldset class="govuk-fieldset" aria-describedby="select-all-that-apply-hint">
<%= govuk_fieldset_header page_title %>
<h2 class="govuk-heading-m" id="select-all-that-apply-hint"><%= t('generic.select_all_that_apply') %></h2>
<span id="select-all-that-apply-hint" class="govuk-hint"><%= t('generic.select_all_that_apply') %></span>

<%= render 'shared/show_errors' unless @form.any_checkbox_checked? %>

Expand Down
2 changes: 1 addition & 1 deletion app/views/shared/forms/other_assets/_form.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<%= govuk_form_group show_error_if: (@form.errors.present? && !@form.any_checkbox_checked?) do %>
<fieldset class="govuk-fieldset" aria-describedby="select-all-that-apply-hint">
<%= govuk_fieldset_header page_title %>
<h2 class="govuk-heading-m" id="select-all-that-apply-hint"><%= t('generic.select_all_that_apply') %></h2>
<span id="select-all-that-apply-hint" class="govuk-hint"><%= t('generic.select_all_that_apply') %></span>

<%= render 'shared/show_errors' %>

Expand Down

0 comments on commit d7239e1

Please sign in to comment.